Fix Error Prone warnings in log4j-api
#1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvz
reviewed
Nov 10, 2023
log4j-api/src/main/java/org/apache/logging/log4j/LogManager.java
Outdated
Show resolved
Hide resolved
jvz
reviewed
Nov 10, 2023
jvz
reviewed
Nov 10, 2023
log4j-api/src/main/java/org/apache/logging/log4j/message/DefaultFlowMessageFactory.java
Outdated
Show resolved
Hide resolved
jvz
reviewed
Nov 10, 2023
log4j-api/src/main/java/org/apache/logging/log4j/message/MessageFormatMessage.java
Show resolved
Hide resolved
jvz
approved these changes
Nov 10, 2023
log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableMessageFactory.java
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/util/LowLevelLogUtil.java
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertySource.java
Show resolved
Hide resolved
ppkarwasz
commented
Nov 13, 2023
log4j-api/src/main/java/org/apache/logging/log4j/message/SimpleMessage.java
Show resolved
Hide resolved
ppkarwasz
force-pushed
the
error-prone
branch
from
d47d8e7
to
2719fb0
Compare
ppkarwasz
force-pushed
the
error-prone
branch
from
2719fb0
to
377d55c
Compare
|
I have refactored all Since |
ppkarwasz
force-pushed
the
error-prone
branch
from
377d55c
to
8e8f85d
Compare
vy
reviewed
Nov 14, 2023
log4j-api/src/main/java/org/apache/logging/log4j/spi/ThreadContextMapFactory.java
Outdated
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/util/Constants.java
Outdated
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/util/ProcessIdUtil.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorUtil.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorUtil.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ContextDataInjectorFactory.java
Outdated
Show resolved
Hide resolved
ppkarwasz
added a commit
to ppkarwasz/logging-log4j2
that referenced
this pull request
Nov 14, 2023
ppkarwasz
force-pushed
the
error-prone
branch
from
63932f9
to
ab48da9
Compare
ppkarwasz
added a commit
to ppkarwasz/logging-log4j2
that referenced
this pull request
Nov 14, 2023
ppkarwasz
force-pushed
the
error-prone
branch
from
ab48da9
to
e74d630
Compare
|
Besides refactoring some bugs indicated by Error Prone, this PR also replaces BND Baseline package exclusions with more limited |
This suppresses or fixes most Error Prone warning in `log4j-api`. Only two dozens warnings are left, mainly in the [TypeParameterUnusedInFormals](https://errorprone.info/bugpattern/TypeParameterUnusedInFormals), which can not be removed for source compatibility reasons. Closes apache#1850.
ppkarwasz
force-pushed
the
error-prone
branch
from
e74d630
to
a19639e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suppresses or fixes most Error Prone warning in
log4j-api.Only two dozens warnings are left, mainly in the
TypeParameterUnusedInFormals, which can not be removed for source compatibility reasons.
Closes #1850.